search

visdesignlab / upset2

UpSet - Visualizing Intersecting Sets
https://upset.multinet.app/
BSD 3-Clause "New" or "Revised" License
42 stars 7 forks source link

Feature: reverse sorting #282

Closed JakeWags closed 7 months ago

JakeWags commented 7 months ago

Does this PR close any open issues?

Closes #254

Give a longer description of what this PR addresses and why it's needed

This PR adds reverse sorting rows for size and degree.

To do so, an optional field sortByOrder is added to relevant sorting functions in packages/core.

Additionally, a new field is added to the UpSet Grammar: sortByOrder (default Ascending). This field only applies to row sorting, is directly beneath sortBy and can be either Ascending or Descending. The addition of this field should not affect existing use cases of the UpSet Grammar, as existing fields are unchanged.

No action is added in Trrack, rather, an optional field is added to the sortBy action, where the config field is set. The provenance tree action is some variation of "Sort by Size, Ascending"

Provide pictures/videos of the behavior before and after these changes (optional)

Provenance tree example: image

Behavior example: upset-reverse-sort

Are there any additional TODOs before this PR is ready to go?

TODOs:

netlify[bot] commented 7 months ago

Deploy Preview for upset2 ready!

Name Link
Latest commit aa2a4f52ff3de51ac14c35ed70fdc24259f8e27a
Latest deploy log https://app.netlify.com/sites/upset2/deploys/65b2dd5442229800089f1a44
Deploy Preview https://deploy-preview-282--upset2.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.