Closed JakeWags closed 7 months ago
Name | Link |
---|---|
Latest commit | 27c5618a6e942bfa7c26f332628fb53187f4a20e |
Latest deploy log | https://app.netlify.com/sites/upset2/deploys/65b2ccf415d441000852eb78 |
Deploy Preview | https://deploy-preview-285--upset2.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Does this PR close any open issues?
Closes #284
Give a longer description of what this PR addresses and why it's needed
This PR adds set size information to
allSets
in the UpSet grammar. This is useful because currently the only way for setSize to be obtained via the grammar is to parse the rawData entry.The
visibleSets
entry remains the same (list of names), as all visible sets are included underallSets
.Here is an example of the new
allSets
field:NOTE: Anywhere that
allSets
is being used in applications which use the grammar will require updates to utilize newly generated grammar.@elizaan upset-alt-txt can be updated accordingly to no longer use rawData if possible
Provide pictures/videos of the behavior before and after these changes (optional)
No changes to user interaction or app behavior
Are there any additional TODOs before this PR is ready to go?
TODOs: