visdesignlab / upset2

UpSet - Visualizing Intersecting Sets
https://upset.multinet.app/
BSD 3-Clause "New" or "Revised" License
42 stars 7 forks source link

Update grammar to include set sizes under "allSets" #285

Closed JakeWags closed 7 months ago

JakeWags commented 7 months ago

Does this PR close any open issues?

Closes #284

Give a longer description of what this PR addresses and why it's needed

This PR adds set size information to allSets in the UpSet grammar. This is useful because currently the only way for setSize to be obtained via the grammar is to parse the rawData entry.

The visibleSets entry remains the same (list of names), as all visible sets are included under allSets.

Here is an example of the new allSets field:

"allSets": [
    {
      "name": "Set_School",
      "size": 6
    },
    {
      "name": "Set_Blue_Hair",
      "size": 3
    },
    {
      "name": "Set_Duff_Fan",
      "size": 6
    },
    {
      "name": "Set_Evil",
      "size": 6
    },
    {
      "name": "Set_Male",
      "size": 18
    },
    {
      "name": "Set_Power_Plant",
      "size": 5
    }
  ]

NOTE: Anywhere that allSets is being used in applications which use the grammar will require updates to utilize newly generated grammar.

@elizaan upset-alt-txt can be updated accordingly to no longer use rawData if possible

Provide pictures/videos of the behavior before and after these changes (optional)

No changes to user interaction or app behavior

Are there any additional TODOs before this PR is ready to go?

TODOs:

netlify[bot] commented 7 months ago

Deploy Preview for upset2 ready!

Name Link
Latest commit 27c5618a6e942bfa7c26f332628fb53187f4a20e
Latest deploy log https://app.netlify.com/sites/upset2/deploys/65b2ccf415d441000852eb78
Deploy Preview https://deploy-preview-285--upset2.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.