visdesignlab / upset2

UpSet - Visualizing Intersecting Sets
https://upset.multinet.app/
BSD 3-Clause "New" or "Revised" License
42 stars 7 forks source link

Add bookmark colors to sizebars #294

Closed JakeWags closed 6 months ago

JakeWags commented 7 months ago

Does this PR close any open issues?

Closes #289

Give a longer description of what this PR addresses and why it's needed

This PR highlights bookmarked rows according to their bookmark color. Additionally it adds a bitwise hex darkening operation which allows for advanced scale darkening for bookmarked rows.

Somewhat arbitrary shading was chosen (12 + (index * 2) as this makes for an appropriate shading without making it too dark.

Provide pictures/videos of the behavior before and after these changes (optional)

image

Are there any additional TODOs before this PR is ready to go?

TODOs:

netlify[bot] commented 7 months ago

Deploy Preview for upset2 ready!

Name Link
Latest commit b5c75d2698711dd5eaa58f94913c375bfcdf4b0b
Latest deploy log https://app.netlify.com/sites/upset2/deploys/65e76782da0d4b0008d626ef
Deploy Preview https://deploy-preview-294--upset2.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.