visdesignlab / upset2

UpSet - Visualizing Intersecting Sets
https://upset.multinet.app/
BSD 3-Clause "New" or "Revised" License
50 stars 7 forks source link

Add sort arrow to column headers (size, deviation/attribute) #295

Closed JakeWags closed 8 months ago

JakeWags commented 8 months ago

Does this PR close any open issues?

Closes #283

Give a longer description of what this PR addresses and why it's needed

This PR adds sort arrows to column headers. They only appear for column headers when the header matches the current sort option (size, deviation, etc). This should be added to the degree column header when the degree column is added (#288)

A custom component wrapper for svgIcon is added called HeaderSortArrow

Provide pictures/videos of the behavior before and after these changes (optional)

image

image

Are there any additional TODOs before this PR is ready to go?

TODOs:

netlify[bot] commented 8 months ago

Deploy Preview for upset2 ready!

Name Link
Latest commit 810e410fc2c81225e42fb49de9096f022d87c92d
Latest deploy log https://app.netlify.com/sites/upset2/deploys/65d51122ac03730008d7d4d9
Deploy Preview https://deploy-preview-295--upset2.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

JackWilb commented 8 months ago

Screenshot 2024-02-12 at 9 49 16 AM

There's a weird layout issue in safari