netlify[bot]
commented
7 months ago Deploy Preview for upset2 ready!
| Name | Link |
|---|---|
| Latest commit | 7a018f154106dceb3eb42e8e692c4258676d2582 |
| Latest deploy log | https://app.netlify.com/sites/upset2/deploys/65d78cf24ec96c0008937160 |
| Deploy Preview | https://deploy-preview-299--upset2.netlify.app/ |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Does this PR close any open issues?
Closes #298
Give a longer description of what this PR addresses and why it's needed
This PR adds a horizontal flag to the grammar (default: false). This is meant for alt-text for horizontal plots. UpSet2 should never set this value to false unless a horizontal implementation is added.
Additionally, this PR refactors the
DefaultConfigto improve DRY principles. By moving this to Core, the defaultConfig can be imported as an object. This means it is defined in only one location and is easily changed.This PR has no effect on behavior of the app or alt-txt.
Provide pictures/videos of the behavior before and after these changes (optional)
Are there any additional TODOs before this PR is ready to go?
TODOs: