visdesignlab / upset2

UpSet - Visualizing Intersecting Sets
https://upset.multinet.app/
BSD 3-Clause "New" or "Revised" License
42 stars 7 forks source link

Upset react build fixes #302

Closed JakeWags closed 6 months ago

JakeWags commented 6 months ago

Does this PR close any open issues?

Closes none

Give a longer description of what this PR addresses and why it's needed

Previously upset-react was failing to build in NPM, causing issues with installing a new package. This resolves that issue by fixing any type errors within Upset. Interestingly, the behavior of the application is completely unaffected and was working fine before.

This fix is necessary because if a new package needs to be installed on the monorepo root level (ex: playwright), there were some interesting hoops to jump through. This fix should make it so there are no problems when setting up and running the repository.

Provide pictures/videos of the behavior before and after these changes (optional)

No behavior changes

Are there any additional TODOs before this PR is ready to go?

TODOs:

netlify[bot] commented 6 months ago

Deploy Preview for upset2 ready!

Name Link
Latest commit 9b316f6e8dd1a831bb563fea8f66c8041eba3260
Latest deploy log https://app.netlify.com/sites/upset2/deploys/65e76380d247b60008be0812
Deploy Preview https://deploy-preview-302--upset2.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.