visdesignlab / upset2

UpSet - Visualizing Intersecting Sets
https://upset.multinet.app/
BSD 3-Clause "New" or "Revised" License
50 stars 7 forks source link

Grammar setnames fix #303

Closed JakeWags closed 7 months ago

JakeWags commented 7 months ago

Does this PR close any open issues?

Closes #301 Depends #302

Give a longer description of what this PR addresses and why it's needed

Previously, there was a strange discrepancy between the downloaded json data setnames and the alt-text generated setnames. This was due to the fact that the alt-text config generation function was not adjusting the element name field prior to export.

By adding this to the alt text, the output seems to be as expected.

Tested with Simpsons and Movie dataset.

Provide pictures/videos of the behavior before and after these changes (optional)

@elizaan Please confirm that this is correct:

 This is an UpSet plot that visualizes set intersection. To learn about UpSet plots, visit https://upset.app.
 Dataset Properties

The dataset contains 6 sets, and 44 elements, of which 6 are shown in the plot.
Set Properties

The largest set is Male with 18 elements, followed by School with 6, Duff Fan with 6, Evil with 6, Power Plant with 5, and Blue Hair with 3.
Intersection Properties

The plot is sorted by size. There are 12 non-empty intersections, all of which are shown in the plot. The largest 5 intersections are School, and Male (3), the empty intersection (3), Just Male (3), Duff Fan, Male, and Power Plant (3), and Evil, and Male (2).
Statistical Information

The average intersection size is 2, and the median is 2. The 90th percentile is 3, and the 10th percentile is 1. The largest set, Male, is present in 75.0% of all non-empty intersections. The smallest set, Blue Hair, is present in 16.7% of all non-empty intersections.

image

Are there any additional TODOs before this PR is ready to go?

TODOs:

netlify[bot] commented 7 months ago

Deploy Preview for upset2 ready!

Name Link
Latest commit 5637779b4afe9bd21e05f0fee6f5fe219431e82d
Latest deploy log https://app.netlify.com/sites/upset2/deploys/65e8a4e5b771fe0008066b5b
Deploy Preview https://deploy-preview-303--upset2.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.