visdesignlab / upset2

UpSet - Visualizing Intersecting Sets
https://upset.multinet.app/
BSD 3-Clause "New" or "Revised" License
42 stars 7 forks source link

Update alt-text generation hook to depend on the currentState #316

Closed JakeWags closed 5 months ago

JakeWags commented 5 months ago

Does this PR close any open issues?

Closes #305

Give a longer description of what this PR addresses and why it's needed

Previously, the alt-text hook needed to be adjusted to include all possible changes which could trigger re-generation. By using the current state as the hook dependency, any state update will cause regeneration.

If the alt-text is ever stored in the state, this may need to be adjusted to accommodate that.

Provide pictures/videos of the behavior before and after these changes (optional)

Have you added or updated relevant tests?

Have you added or updated relevant documentation?

Are there any additional TODOs before this PR is ready to go?

TODOs:

netlify[bot] commented 5 months ago

Deploy Preview for upset2 ready!

Name Link
Latest commit 3641bd96d46c09c6aca5631f3eea6c6cbbb3e690
Latest deploy log https://app.netlify.com/sites/upset2/deploys/660344b118e74a0008ec45f7
Deploy Preview https://deploy-preview-316--upset2.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.