visdesignlab / upset2

UpSet - Visualizing Intersecting Sets
https://upset.multinet.app/
BSD 3-Clause "New" or "Revised" License
41 stars 7 forks source link

Fix display name for intersections in element sidebar #318

Closed NateLanza closed 4 months ago

NateLanza commented 4 months ago

Does this PR close any open issues?

Closes #311

Give a longer description of what this PR addresses and why it's needed

This fix replaces the ~&~ delimiter between set names in subset labels with a more readable & by creating a selected element display name, using it instead of the intersection name, and passing it to the bookmark function.

Provide pictures/videos of the behavior before and after these changes (optional)

Have you added or updated relevant tests?

Have you added or updated relevant documentation?

Are there any additional TODOs before this PR is ready to go?

No

netlify[bot] commented 4 months ago

Deploy Preview for upset2 ready!

Name Link
Latest commit 29203ceb2936627d94728ef69b5532995db219a9
Latest deploy log https://app.netlify.com/sites/upset2/deploys/65f9af5803342f00083add1f
Deploy Preview https://deploy-preview-318--upset2.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.