search

visdesignlab / upset2

UpSet - Visualizing Intersecting Sets
https://upset.multinet.app/
BSD 3-Clause "New" or "Revised" License
43 stars 7 forks source link

Ensure UpSet table always scrolls horizontally when needed #321

Closed NateLanza closed 6 months ago

NateLanza commented 6 months ago

Does this PR close any open issues?

Closes #286

Give a longer description of what this PR addresses and why it's needed

Previously, the UpSet table behaved as though it had overflow: hidden (in reality, it was simply expanding off the screen & not viewable). By setting a max-width for the body element, the table becomes horizontally scrollable, addressing the issue of sidebars covering the table contents.

Provide pictures/videos of the behavior before and after these changes (optional)

Have you added or updated relevant tests?

Have you added or updated relevant documentation?

Are there any additional TODOs before this PR is ready to go?

TODOs:

netlify[bot] commented 6 months ago

Deploy Preview for upset2 ready!

Name Link
Latest commit 3d97f1d58a858c588a0f8cc3c5115ea585946233
Latest deploy log https://app.netlify.com/sites/upset2/deploys/6601a71dc2b6d8000863573a
Deploy Preview https://deploy-preview-321--upset2.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

NateLanza commented 6 months ago

Approved. Does this do the same thing when using "100%" rather than "100vw"?

Probably! I don't see either option being preferable to the other with the current page architecture.