visdesignlab / upset2

UpSet - Visualizing Intersecting Sets
https://upset.multinet.app/
BSD 3-Clause "New" or "Revised" License
41 stars 7 forks source link

Remove `getId` call from set id generation #323

Closed JakeWags closed 4 months ago

JakeWags commented 4 months ago

Does this PR close any open issues?

Closes #322

Give a longer description of what this PR addresses and why it's needed

This PR removes the getId call from the set's id generation to remove any interference with existing set names. The _ filtering isn't being used anywhere, and so this can be entirely removed.

Provide pictures/videos of the behavior before and after these changes (optional)

Old alt-text:

image

Updated alt-text:

image

Old data-table (visible sets):

image

Update data-table (visible sets):

image

Have you added or updated relevant tests?

Have you added or updated relevant documentation?

Are there any additional TODOs before this PR is ready to go?

TODOs:

netlify[bot] commented 4 months ago

Deploy Preview for upset2 ready!

Name Link
Latest commit 027adf416fb5b6cecab6bb5de49052b9861025a5
Latest deploy log https://app.netlify.com/sites/upset2/deploys/6601b986c8e5b100083680e5
Deploy Preview https://deploy-preview-323--upset2.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.