visdesignlab / upset2

UpSet - Visualizing Intersecting Sets
https://upset.multinet.app/
BSD 3-Clause "New" or "Revised" License
43 stars 7 forks source link

Fix row selection being removed when clicking off of chart #325

Closed JakeWags closed 6 months ago

JakeWags commented 6 months ago

Does this PR close any open issues?

Closes #307 Also closes #317

Give a longer description of what this PR addresses and why it's needed

This PR adds an event listener for removing column hover state when moving the mouse outside the UpSet plot. Additionally, this PR removes the event listener for removing the click state. This was causing issues with interaction with the elementView sidebar. The user can only deselect an element by clicking on a selected row.

Provide pictures/videos of the behavior before and after these changes (optional)

Updated behavior

upset-column-highlights

Have you added or updated relevant tests?

Have you added or updated relevant documentation?

Are there any additional TODOs before this PR is ready to go?

TODOs:

netlify[bot] commented 6 months ago

Deploy Preview for upset2 ready!

Name Link
Latest commit 800125d539e44f21c8b4c908166a014e0674f844
Latest deploy log https://app.netlify.com/sites/upset2/deploys/66059af133834800089d74de
Deploy Preview https://deploy-preview-325--upset2.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.