visdesignlab / upset2

UpSet - Visualizing Intersecting Sets
https://upset.multinet.app/
BSD 3-Clause "New" or "Revised" License
41 stars 7 forks source link

Ensure set scale updates when sets are added and removed #337

Closed NateLanza closed 3 months ago

NateLanza commented 3 months ago

Does this PR close any open issues?

Closes #247

Give a longer description of what this PR addresses and why it's needed

Previously, the set scale would not update when the max visible intersection size changed due to sets being added/removed. This PR updates some conditional logic to ensure that the scale always updates when advanced scale is toggled off and sets are added or removed.

Provide pictures/videos of the behavior before and after these changes (optional)

Before: 247-before After: 247-after

Have you added or updated relevant tests?

Have you added or updated relevant documentation?

Are there any additional TODOs before this PR is ready to go?

No

netlify[bot] commented 3 months ago

Deploy Preview for upset2 ready!

Name Link
Latest commit 4cd304c0c559feb629096e32c7e2903e7bd5cdf3
Latest deploy log https://app.netlify.com/sites/upset2/deploys/661058ab4f0c6d0008cabe5c
Deploy Preview https://deploy-preview-337--upset2.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.