netlify[bot]
commented
3 months ago Deploy Preview for upset2 ready!
| Name | Link |
|---|---|
| Latest commit | 8a187f488086a51400ecb7b5b44f5dea44ba2866 |
| Latest deploy log | https://app.netlify.com/sites/upset2/deploys/661611014a4dc100086f6052 |
| Deploy Preview | https://deploy-preview-351--upset2.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Does this PR close any open issues?
Closes #345
Give a longer description of what this PR addresses and why it's needed
Removes the "Submit" and "Cancel" buttons from the attribute dropdown and instead updates the plot immediately when attributes are selected and deselected. No replacement is necessary for the "Cancel" button, as clicking off the menu closes it.
Provide pictures/videos of the behavior before and after these changes (optional)
Before:
After:
Have you added or updated relevant tests?
Have you added or updated relevant documentation?
Are there any additional TODOs before this PR is ready to go?
No
Note to reviewers
I changed the file from 4-space to 2-space indentation to be more consistent with the rest of the repo, causing Github to show a replacement diff on all indented lines. If you deselect the first commit (which contains the indentation changes and some added documentation) you'll only see the code diffs.