visdesignlab / upset2

UpSet - Visualizing Intersecting Sets
https://upset.multinet.app/
BSD 3-Clause "New" or "Revised" License
43 stars 7 forks source link

Attribute consolidation #352

Closed JakeWags closed 5 months ago

JakeWags commented 5 months ago

Does this PR close any open issues?

Closes #297 #308 #22 #123

Give a longer description of what this PR addresses and why it's needed

This PR consolidates both Deviation and Degree into the attribute list so that the columns can be removed, and eventually universally sorted by. This improves the dynamic UI (see #1 ) and makes the sorting refactor (#123 ) for attributes simpler in the future, as hard coded sort values are now included in the attribute list.

Note: Deviation will always appear as the first item in the attributes list, as it isn't really an attribute, but is handled in a similar way by the dropdown menu.

Bundled in with this is a mini-refactor of attribute header and bar rendering to improve readability and scalability.

Provide pictures/videos of the behavior before and after these changes (optional)

BEFORE:

upset-attr-consolidation-before

AFTER:

upset-attr-consolidation

Have you added or updated relevant tests?

Have you added or updated relevant documentation?

Are there any additional TODOs before this PR is ready to go?

TODOs:

netlify[bot] commented 5 months ago

Deploy Preview for upset2 ready!

Name Link
Latest commit 65795487de496d33cb0adfe2fb40e3c680c20a07
Latest deploy log https://app.netlify.com/sites/upset2/deploys/6633da9f72890c0008dd0584
Deploy Preview https://deploy-preview-352--upset2.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.