search

visdesignlab / upset2

UpSet - Visualizing Intersecting Sets
https://upset.multinet.app/
BSD 3-Clause "New" or "Revised" License
41 stars 7 forks source link

346 datatable improvements #365

Closed JakeWags closed 1 month ago

JakeWags commented 1 month ago

Does this PR close any open issues?

Closes #346

Give a longer description of what this PR addresses and why it's needed

This PR makes the following changes:

  1. Upset Data Table rename to Intersection Data
  2. Add Deviation column to the table
  3. Add each attribute to the data table (using the mean value for the subset)

Provide pictures/videos of the behavior before and after these changes (optional)

before: image

after: 346-after

Have you added or updated relevant tests?

Have you added or updated relevant documentation?

Are there any additional TODOs before this PR is ready to go?

TODOs:

netlify[bot] commented 1 month ago

Deploy Preview for upset2 ready!

Name Link
Latest commit 9c55bbff29a09fd3daae8e0d7dd44b6a8174d4aa
Latest deploy log https://app.netlify.com/sites/upset2/deploys/666b151b7de6820008a23439
Deploy Preview https://deploy-preview-365--upset2.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

JakeWags commented 1 month ago

LGTM, though it's a good idea to also have @JackWilb review because I'm not familiar with this part of the codebase or localforage.

No changes were made to the localforage data storage in this PR. It looks like it because of those damn tab spacing changes.