visdesignlab / upset2

UpSet - Visualizing Intersecting Sets
https://upset.multinet.app/
BSD 3-Clause "New" or "Revised" License
42 stars 7 forks source link

Fix deviation scale being shifted by 1/2 attribute bar width #387

Closed JakeWags closed 2 weeks ago

JakeWags commented 2 weeks ago

Does this PR close any open issues?

Closes #386

Give a longer description of what this PR addresses and why it's needed

This PR fixes a deviation bar scale issue. The bar was scaled using dimensions.attribute.width / 2 when it needed to be dimensions.attribute.width. This was causing near 0 values to always go out to halfway to the maximum bar size.

Provide pictures/videos of the behavior before and after these changes (optional)

BEFORE: image

AFTER: image

note: The numbers only appear as part of the debugging process.

Have you added or updated relevant tests?

Have you added or updated relevant documentation?

Are there any additional TODOs before this PR is ready to go?

TODOs:

netlify[bot] commented 2 weeks ago

Deploy Preview for upset2 ready!

Name Link
Latest commit 90d632cfbb2a28a641defbd0dc54aec17d2a928d
Latest deploy log https://app.netlify.com/sites/upset2/deploys/66d09fc4ba77e3000830eb23
Deploy Preview https://deploy-preview-387--upset2.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.