search

visdesignlab / visdesignlab.github.io

https://vdl.sci.utah.edu/
BSD 3-Clause "New" or "Revised" License
6 stars 21 forks source link

GitHub Actions LinkChecker failing on new file initialization #124

Closed JakeWags closed 1 year ago

JakeWags commented 1 year ago

LinkChecker Action fails upon creating a new file.

This is most likely due to the canonical header link using an absolute url, so html-proofer treats it as an external link. Since the file has not been published yet, the action fails with a 404 status for each link pointing to the new file.

JakeWags commented 1 year ago

See #121 and #122 CheckLinks failures due to 404 status on "external" links pointing towards self.

JakeWags commented 1 year ago

Pull Request #123 potentially solves the issue via data-proofer-ignore. Reference html-proofer issue #170.

A test branch was made with a fake new file and the CheckLinks action passed. Close this after a PR comes through with a new page and the test passes.

JackWilb commented 1 year ago

We'll be testing this on the ferret branch PR