search

visenze / visenze-gtm

Apache License 2.0
0 stars 0 forks source link

Use EncodeUri() if part of the URL path or EncodeUriComponent() if used as a URL parameter #14

Open semisight opened 1 year ago

semisight commented 1 year ago

When reviewing your template we've noticed that it is using parameters to build a url. It's a best practice to use EncodeUri() if part of the URL path or EncodeUriComponent() if used as a URL parameter.

wjlee-visenze commented 5 months ago

Hi @semisight, apologies for leaving the issue open for so long.

We have had a few version updates since then, the latest commit includes the EncodeUriComponent changes as suggested. Could you check it again?

Thanks!