[Bug] Unbreak publishing

visgl / deck.gl-community

Community contributed modules for deck.gl

https://visgl.github.io/deck.gl-community/

MIT License

37 stars 20 forks source link

[Bug] Unbreak publishing #126

Closed ibgreen closed 2 months ago

ibgreen commented 3 months ago

Module

[X] deck.gl-community/arrow-layers
[X] deck.gl-community/bing-maps
[X] deck.gl-community/editable-layers
[X] deck.gl-community/experimental
[X] deck.gl-community/graph-layers
[X] deck.gl-community/layers
[X] deck.gl-community/react
[X] deck.gl-community/react-graph-layer

Description

yarn run publish-prod does not actually publish anything

Expected Behavior

No response

Steps to Reproduce

yarn run publish-prod

Environment

Framework version: deck.gl-community@9
Browser:
OS:

Logs

No response

ibgreen commented 3 months ago

yarn run publish-prod just terminates after / in the tests. If the expectation is that the actual publish would happen through a github action, 1) that action is not in place 2) it would be nice with a message in the console indicating that this is what is happening.

Pessimistress commented 3 months ago

Probably because there's no packages defined in lerna.json.

ibgreen commented 3 months ago

OK will add. Strangely it did however publish fine before with this lerna.json

ibgreen commented 3 months ago

Probably because there's no packages defined in lerna.json

Tried adding modules (https://github.com/visgl/deck.gl-community/pull/127). But yarn run publish-prod is still a silent quitter.

donmccurdy commented 3 months ago

lerna.json#packages is optional in newer Lerna versions, and defaults to package.json#workspaces. Assuming that we do want Lerna to manage all of the workspaces, perhaps we want to remove the requirement of having lerna.json#packages eventually.