Open alasarr opened 1 year ago
No doubt such widgets would be exceedingly useful and popular, and if you are willing to lead and contribute to this, we will find a way!
A couple of concerns from my side:
Depending on scope, it could be a separate module but perhaps eventually even a separate, composable framework. As an example math.gl and loaders.gl both grew out of luma.gl, as the code base became too big.
Examples of data separation issues:
Thanks @ibgreen for your comments. They have really helped me to evolve the idea of this feature. During this time I have seen the following issues:
Having the previous two issues in mind I'm more likely to go for the following solution.
DataFilterExtension
to be able to apply more filters in the GPU (like categories). That's for me something to do independently of this feature.Filtering system
Widgets can filter a layer (that's why we need to improve the DataFilterExtension
).
Widgets can filter between themselves.
Widgets can be filtered by the viewport of the map.
To implement this we need a filtering language that could be serialized/deserialized. The JS function used to populate the data will require to receive the filters and pass it to the backend.
const dataSource = new WidgetDataSource({
filters: {...},
data: async ({filters}) => {
const url = `https://${apiBaseUrl}/widgets/formula?filters=${filters}`;
const response = await fetch(url);
return response.json();
}
})
I'd like to design a data source concept to have a better separation between data/ui.
I would like to hear your thoughts about this approach. I'm aware it's not completed, but I'd like to gather some feedback before moving forward.
Target Use Case
In v9, we are working on the new widgets module, I would like to propose adding a set of advanced data widgets, which allows not only a visual representation but a rich interaction with data & map layers, such as filtering or an automatic data refresh on viewport change.
Consider the following dataset:
A widget for the previous dataset looks like this:
A widget allows:
The widget has two modes: global or viewport. When the viewport is enabled the data of the widget is filtered based on the viewport (so it's updated when the ViewState changes).
Multiple widgets are available, check here the different types of widgets.
It's a very common feature widely used in App Development at CARTO, but there is a strong limitation, they are only available via CARTO for React, so:
I feel this would be a great feature to add because:
This map includes a layer with widgets where you can see this functionality in action.
Proposal
This proposal is not simple as it will require deciding on multiple things of the core, so I'm writing down the first ideas, but in this case, I feel we will need a design meeting and move from there.
A new set of widgets could be incorporated into the new widgets module (@deck.gl/widgets):
A widget is linked to a layer via the
layerId
prop. A widget can filter a layer whenallowFilterLayer
is set to true. Widgets can filter other widgets if they are associated with the same layer. Check this example to see the expected functionality in action.Filtering system As the widgets filter each other, a common state between widgets is required to manage the filtering.
Each widget (except the formula) should be able to filter the layer in the map, in other words, each widget defines a way to filter the layer, and the current implementation of DataFilterExtension doesn't support all the filters required by the widgets. I think it's a great opportunity to expand it as it was commented at https://github.com/visgl/deck.gl/issues/7827#issuecomment-1505013840. For example, @felixpalmer added support to filter by category at https://github.com/visgl/deck.gl/issues/7827.
TODO: I will add during the following days a table with the filters each widget requires in the layer.
Gathering data The initial idea is that the layer will provide the data for the widgets. It should return the data filtered by the viewport (when filterByViewport is true). It's not the rendered data because the widgets are showing the filtered values too.
Tile Layers
Tile layers (like MVT generated with Tippecanoe) sometimes drop features at lower zoom levels to reduce the tile size. For example, a layer of zipcodes at Z=3 doesn't include all the features. Tilers often keep the most prominent features to guarantee a decent size of tiles across multiple zoom levels. If the widgets are calculated with the data of the tiles the result is not always accurate because some features could have been dropped. For those use cases, a backend is required to perform an accurate calculation; or limit the zoom level where the widget is available to guarantee the data is accurate.
For instance, CARTO has two internal modes to calculate widgets: with the data of the tile (for tilesets) and with an external API (for tables and queries).
An option might be to include a prop with an async function to be used in that case.
Scope I would keep it at the beginning for the GeoJSON layer and the MVTLayer. We can also reduce the number of widgets to include in v1. We can start with Formula, Category, and Histogram
In general, it's a very large feature. If we decide to go ahead, we will need to split it into smaller pieces.
Should we require a new module for these widgets? Maybe it's too soon yet, but the features required for those data widgets could be more specific. Something to decide as the RFC is taking shape...