search

visgl / loaders.gl

Loaders for big data visualization. Website:
https://loaders.gl
Other
678 stars 187 forks source link

fix(loader-utils): add missing dependency on @probe.gl/log #3008

Closed davidcalhoun closed 2 months ago

davidcalhoun commented 2 months ago

/modules/loader-utils/src/lib/log-utils/log.ts depends on @probe.gl/log, so this package should be added to package dependencies.

Currently this results in an error when using @loaders.gl/loader-utils@4.2.1 with Yarn:

Cannot find module '@probe.gl/log' from '[REDACTED]/.yarn/__virtual__/@loaders.gl-loader-utils-virtual-7093831d78/0/cache/@loaders.gl-loader-utils-npm-4.2.1-a254ec9477-03fd9b18c2.zip/node_modules/@loaders.gl/loader-utils/dist'

Note: workaround until this PR is merged:

# .yarnrc.yml
packageExtensions:
  "@loaders.gl/loader-utils@*":
    dependencies:
      "@probe.gl/log": "*"
ibgreen commented 2 months ago

@davidcalhoun Thanks for submitting a PR. This breaks on CI since the lock file wasn't updated. I will land and fix separately.