search

visgl / loaders.gl

Loaders for big data visualization. Website:
https://loaders.gl
Other
678 stars 187 forks source link

fix(csv): move d3-dsv from devDependencies to dependencies #3009

Closed davidcalhoun closed 2 months ago

davidcalhoun commented 2 months ago

Note: this PR is similar to #3008

/modules/csv/src/lib/encoders/encode-csv.ts depends on d3-dsv, so this package should be added to package dependencies. Previously this import was in devDependencies (looks like a test also imports it), but since this is code that runs in production is should be moved to dependencies

Currently this results in an error when using @loaders.gl/csv@4.2.1 with Yarn:

Cannot find module 'd3-dsv' ...

Note: workaround until this PR is merged:

# .yarnrc.yml
packageExtensions:
  "@loaders.gl/csv@*":
    dependencies:
      "d3-dsv": "*"
ibgreen commented 2 months ago

@davidcalhoun Thanks for the PR, same deal as the other one, I will land and fix afterwards.

davidcalhoun commented 2 months ago

@ibgreen Thanks, sorry about that! Thanks for the fast response on both.