Open amuedespacher opened 1 month ago
When working on a map that uses quantized-mesh based terrain tiles, I realized that the documentation regarding skirtHeight on the QuantizedMeshLoader is incorrect.
skirtHeight
QuantizedMeshLoader
Steps to reproduce:
.terrain
TileLayer
SimpleMeshLayer
terrain.skirtHeight
100
Actual result:
quantized-mesh.skirtHeight
Expected result
When working on a map that uses quantized-mesh based terrain tiles, I realized that the documentation regarding
skirtHeight
on theQuantizedMeshLoader
is incorrect.Steps to reproduce:
.terrain
tiles withQuantizedMeshLoader
and render it with e.g. deck.gl'sTileLayer
(andSimpleMeshLayer
as sub-layer).terrain.skirtHeight
option (as per documentation) and set it to e.g.100
(meter) to generate a skirt.Actual result:
skirtHeight
is defined asquantized-mesh.skirtHeight
instead, as can be read from the interface in https://github.com/visgl/loaders.gl/blob/88ca35c545a92d28350d073be74e1f540d42a806/modules/terrain/src/quantized-mesh-loader.ts#L13Expected result