search

visgl / loaders.gl

Loaders for big data visualization. Website:
https://loaders.gl
Other
678 stars 187 forks source link

Tiles traverser: do not check for visibility in `canTraverse`. (#3032) #3039

Open Avnerus opened 3 weeks ago

Avnerus commented 3 weeks ago

Hi, This is a version of PR #3032 for the 4.2-release branch.

ibgreen commented 3 weeks ago

Make sure to check in the lock file. If you install locally and the lock file doesn't change you may want to install volta, which automatically configures yarn and node versions.

Avnerus commented 3 weeks ago

Ah I see. It did change, but I thought I should not commit it to avoid unnecessary changes to the branch. I'll add it then.

Avnerus commented 3 weeks ago

The current failure happened to me locally as well but I was hoping it was only local. I checked it earlier and this seems to be something that was fixed in master in the parquet module.

ibgreen commented 3 weeks ago

The current failure happened to me locally as well but I was hoping it was only local. I checked it earlier and this seems to be something that was fixed in master in the parquet module.

Hmm yes, it looks like the 4.2-release branch may have experienced some "rot".

Avnerus commented 3 weeks ago

The current failure happened to me locally as well but I was hoping it was only local. I checked it earlier and this seems to be something that was fixed in master in the parquet module.

Hmm yes, it looks like the 4.2-release branch may have experienced some "rot".

Would it be easier to merge this against 4.1?