Tracker: v9 glTF support

visgl / luma.gl

High-performance Toolkit for WebGL-based Data Visualization

https://luma.gl

Other

2.32k stars 211 forks source link

Tracker: v9 glTF support #1847

Open felixpalmer opened 11 months ago

felixpalmer commented 11 months ago

Task list for GLTF support in v9

also see https://github.com/visgl/luma.gl/issues/702

v9.0

[x] Initial implementation https://github.com/visgl/luma.gl/pull/1819
[x] Release gltf package on npm

v9.1

[ ] Remove gltf loaders.gl/math dependency once https://github.com/visgl/loaders.gl/pull/2808 deployed
[ ] Update website/package.json with gltf dependency
[ ] More tests
[ ] Remove GLTF attribute name mapping in GPUGeometry
[ ] Upgrade guide mention GLTF
[ ] Support IBL (if we postpone, we must document as limitation in luma v9 release notes)
[ ] gltf bounding box courtesy method
[ ] Extract gltf-instantiator to function

chrisgervang commented 11 months ago

Fantastic work bringing gltf into v9 @felixpalmer ! @ibgreen made a passing comment that imageBasedLightingEnvironment might not be used by deck and may not have been ported as a result. Deck has a prop for it that I've used successfully in the past. While not critical, I wanted to call it out in case you weren't aware.

ibgreen commented 11 months ago

We used to have a showcase example for gltf (currently in examples-wip folder) that did create IBL lighting. @felixpalmer create a new simpler glTF tutorial example

I didn't confirm that IBL didn't work but it required cube textures and I think those are broken right now.

felixpalmer commented 10 months ago

@chrisgervang @ibgreen I've added a task to the list above to include IBL. I have it as lower priority as my primary objective is getting something rendering in deck so we can port the layers that depend on GLTF

ibgreen commented 10 months ago

Makes sense, I suggest we save our effort and fix this after the texture refactor in #1860 lands.