Code Formatting #110 resolved

chttrjeankr commented 4 years ago

Fixes #110

Description:

Files changed: nearly all .py files
Dependencies if any:
- May cause conflict to PRs working on databaseconnect.py
- Causes Travis CI to fail at test_googleMapsApiModule.py due to Invalid API Key. Maybe need to take a look into that separately.
Basic tests done to validate:
- Run Telegram setup after commit from scratch.
- Used flake8 and black to check for errors during Travis CI build.
Conflicts if any: With PR #93

Checklist:

[x] All coding conventions are followed: Used black and flake8 to validate.
[x] Style guidelines for this project have been followed
[x] 4 space indentation is used
[x] Relevant comments are added
[x] The code has been tested
[x] No new warnings are generated: apart from Travis CI build error.

Screenshots:

None

Other Information:

None. Comments are added to the PR for extra clarifications.

@vishakha-lall @janakrajchadha

chttrjeankr commented 4 years ago

Took some time to go through the entire set of changes. Looks good to me apart from the minor changes suggested by @chttrjeankr. Once those are made, it can be merged.

Those changes are some logical changes that would be better taken up as a different issue. I feel mixing code formatting with logical changes would lead to confusion.

vishakha-lall commented 4 years ago

@chttrjeankr Can you resolve the merge conflicts? Also, do you mind ignoring the test_googleMapsApiModule.py as discussed here in the same PR?

chttrjeankr commented 4 years ago

Also, do you mind ignoring the test_googleMapsApiModule.py as discussed here in the same PR?

Since, there are no other tests right now for pytest, if we ignore the test_googleMapsApiModule.py, pytest exits with failure code 5, because no tests are being run. I'd request to wait for #103 to be merged and then proceed to ignore the mentioned case.

vishakha-lall commented 4 years ago

Sounds fair! Can you resolve the merge conflicts?

vishakha-lall / MapBot