vishakha-lall / MapBot

A chatbot developed in Python
MIT License
145 stars 108 forks source link

Code Formatting #110 resolved #111

Closed chttrjeankr closed 4 years ago

chttrjeankr commented 4 years ago

Fixes #110

Description:

Checklist:

Screenshots:

None

Other Information:

None. Comments are added to the PR for extra clarifications.

@vishakha-lall @janakrajchadha

chttrjeankr commented 4 years ago

Took some time to go through the entire set of changes. Looks good to me apart from the minor changes suggested by @chttrjeankr. Once those are made, it can be merged.

Those changes are some logical changes that would be better taken up as a different issue. I feel mixing code formatting with logical changes would lead to confusion.

vishakha-lall commented 4 years ago

@chttrjeankr Can you resolve the merge conflicts? Also, do you mind ignoring the test_googleMapsApiModule.py as discussed here in the same PR?

chttrjeankr commented 4 years ago

Also, do you mind ignoring the test_googleMapsApiModule.py as discussed here in the same PR?

Since, there are no other tests right now for pytest, if we ignore the test_googleMapsApiModule.py, pytest exits with failure code 5, because no tests are being run. I'd request to wait for #103 to be merged and then proceed to ignore the mentioned case.

vishakha-lall commented 4 years ago

Sounds fair! Can you resolve the merge conflicts?