vishakha-lall / MapBot

A chatbot developed in Python
MIT License
145 stars 108 forks source link

Integrate timezone API call to bot response #132

Closed vishakha-lall closed 4 years ago

vishakha-lall commented 4 years ago

Is your feature request related to a problem? Please describe. While googleMapsApiModule.py has already implemented timezone as a module, it is desired that the results of these API are seen in bot conversations.

Describe the solution you'd like This issue would would require carefully studying the intent of the API, the kind of response it returns. On the basis of these, the following must be addressed

Describe alternatives you've considered NA

Additional context These changes would be required in chatbot.py and similar implementations for Directions API can be used as guidelines.

chttrjeankr commented 4 years ago

I'd like to start working on this. @vishakha-lall

chttrjeankr commented 4 years ago

What queries are we trying to handle while dealing with the Timezone API? I can think of the following examples:

Would you want to add on some more examples to this list? @vishakha-lall

vishakha-lall commented 4 years ago

What queries are we trying to handle while dealing with the Timezone API? I can think of the following examples:

  • What is the time at <PLACE>?
  • What time is it now at <PLACE>?
  • Which timezone is <PLACE> located in?
  • What is the timezone at <PLACE>?

Would you want to add on some more examples to this list? @vishakha-lall

These look good, go ahead. As of now, I can't think of anymore.

chttrjeankr commented 4 years ago

A minor blocker:

are being classified as a C (chat) by the utilities.classify_sentence() and thus leading to crashes in databaseconnect.py.

Though, the above sentence is being classified as Q (question) correctly.

I'm planning to ignore tests of the misclassified sentence since it's out of scope for this issue. Your views, @vishakha-lall ?