search

vishakha-lall / MapBot

A chatbot developed in Python
MIT License
145 stars 108 forks source link

Checking all kinds of queries for possible GMapsAPI calls #145

Closed chttrjeankr closed 4 years ago

chttrjeankr commented 4 years ago

Describe the bug Currently, the code tries to check only the queries classified as question by the classifier. We've to make sure even statement and chat type queries receive correct answers if they contain something related to the GMaps API.

To Reproduce Steps to reproduce the behaviour:

  1. Ask the bot "What time is it now at California?" (ref: this)
  2. The bot doesn't form the answer correctly.

Expected behavior All queries will undergo checks if the subjects/root words in them point to calls to the GMapsAPI.

Additional context None

chttrjeankr commented 4 years ago

I would like to work on a fix.

chttrjeankr commented 4 years ago

Code changes for this issue would create serious merge conflicts in #144 as both will deal with chatbot.py. I'd request to wait for that one to be merged before I can create a PR for this issue.