search

vishal2376 / snaptick

Snaptick is an MVVM Jetpack Compose app, offering ad-free task management with a built-in pomodoro timer to help you organize your daily plans
GNU General Public License v3.0
301 stars 23 forks source link

fix #68: Set status bar appearance based on theme #73

Closed SriMani-7 closed 4 weeks ago

SriMani-7 commented 1 month ago

Fix status bar appearing black in dark theme #68

I have implemented a fix that conditionally sets the WindowInsetsControllerCompat.isAppearanceLightStatusBars variable based on the app theme.

vishal2376 commented 1 month ago

Please Attach Screenshots of both Light and Dark Mode

SriMani-7 commented 4 weeks ago

Please Attach Screenshots of both Light and Dark Mode

Screenshots

Light theme Dark theme Amoled theme
Light theme screenshot Dark theme screenshot
Amoled theme screenshot
vishal2376 commented 4 weeks ago

OK, code is working fine.

But 1 line of code doesn't justify 4 commit. Please do not make extra irrelevant commits

Make single commit of your changes, then i will merge you PR

If you encounter problem then create a new PR with single commit and don't forget to include issue number and screenshots in description of PR