Closed fnimick closed 8 months ago
This happens due to TRPCQueryOpts now being required on createQuery: https://github.com/vishalbalaji/trpc-svelte-query-adapter/blob/481aa9bb894542980c4101a0dbbeb71295f7b111/src/index.ts#L207
TRPCQueryOpts
createQuery
Based on my cursor read, this isn't required since all lookups are of opts?.trpc?.abortOnUnmount - implying that null values are valid here. Should the type be changed?
opts?.trpc?.abortOnUnmount
You are absolutely right, both trpc and abortOnUnmount should be optional. Thanks a lot for pointing this out!
trpc
abortOnUnmount
This happens due to
TRPCQueryOpts
now being required oncreateQuery
: https://github.com/vishalbalaji/trpc-svelte-query-adapter/blob/481aa9bb894542980c4101a0dbbeb71295f7b111/src/index.ts#L207Based on my cursor read, this isn't required since all lookups are of
opts?.trpc?.abortOnUnmount
- implying that null values are valid here. Should the type be changed?