search

vishalival / eep153-john-graunt

0 stars 0 forks source link

Evelyn Kitagawa Code Review #1

Open boricuamkw opened 8 months ago

boricuamkw commented 8 months ago

# Print graph from 1960-2022 life_expectancy.iplot(title="Life expectancy at birth: 1960-2022",xTitle='Year',yTitle='Years')

xTitle='Year' and yTitle='Years' are very similar at first glance. Would it be possible to clarify that yTitle='Years' is in relation to years of life expectancy at birth? Just a small detail :)

boricuamkw commented 8 months ago

In [5], [11] and [13], the """ x """ is a little distracting instead of using #. It seems like the """x""" is for titles, so maybe splitting up the code into more cells and adding markdown text can make it more readable. This is just an aesthetic detail.

boricuamkw commented 8 months ago

Overall very organized and clean. Effective use of comments and descriptors. Unit Tests work.