Thomas Greville Code Review

[amandaneslund]

Your guys project looks great so far! I can clearly tell the high level of effort and organization that went into the code. Below are a couple of things my group noticed.

• The table of contents in the beginning is really helpful and well organized .
• The population data frame column output has a lot of great information but is a little difficult to read. I think it could be a more streamlined table produced or another type of visual might be easier to comprehend. I would also relabel the categories on the x-axis and remove the word population from every label. It might just make the table easier to read if population was its own heading.
• The animated population pyramid is really impressive and the amount of graphics for so many different categories really highlights all the effort put into this project. I particularly found the net migration in neighboring countries as a percentage of total population fascinating. This is a graph I would make sure to highlight and discuss thoroughly in your video.
• The unit tests are very through as well.
• All of the comments in the code made it very easy to read as well and all the comments walking through each function is wonderful.
• I think the project is really good and detailed I would just elaborate on the “so what” aspect in your video. There’s a lot of great data but I want to know how this analysis is applicable today or what other applications this analysis has in the real world. Maybe you could connect it to genocides happening around the world today or future economic/political/population development in Rwanda today.
• I think it would be interesting too to “zoom” in on some of the graphs and focus more about the changes right before and after 1994. You could even make two versions of your graph with the whole time scale and a “zoomed in” version just focusing right around 1994. This would especially helpful in reading the net migration graphs.
• The population by gender in percentage visual is slightly confusing. Maybe it just needs more explanation in the video. Just wondering how it is related to the genocide. If it is not relevant findings I would eliminate since you have stronger less confusing visuals.

Overall the project looks great and its evident how much time and detail went into creating all the code and graphics! Super impressed!

[vishalival]

Thank you for your comments, and we will take everything into consideration. Appreciate it!!