vishandi / pe

0 stars 0 forks source link

Unclear rule on duplicate entries #5

Open vishandi opened 2 years ago

vishandi commented 2 years ago

image.png

image.png
This is the initial situation.

At first I thought nothing stated in the UG about duplicate entries, I assumed everything needs to be equal to be considered as duplicates. However, these two inconsistent behaviour occurs:

  1. Different address (Accepted)

image.png

  1. Different breed (Not accepted)

image.png

soc-se-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Too loose restrictions on duplicates

add n/AAA o/John Doe p/98765432 a/311, Clementi Ave 2 add n/AAA o/John Doe p/98765432 a/311, Clementi Ave 2, #02-25 t/Mini Beagle are considered as different pets because the addresses are in different extend of specification I personally feel like if name of the pet, name of the onwer and phone number are the same, we can safely decide that the two pets are identical It can be a serious problem if users cannot key in their addresses (or maybe the customer cannot say it the same) exactly the same each time they try to register a customer


[original: nus-cs2103-AY2122S2/pe-interim#848] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

It is possible for the same owner to have two or in fact multiple addresses, from our teammates' personal experience working in a pet daycare center.

Additionally, it should not be of medium severity since it is rare for users to even key in the inputs above.

Since it is non-occasional, it should be of low severity instead.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]