vishank848 / owasp-esapi-java

Automatically exported from code.google.com/p/owasp-esapi-java
Other
4 stars 2 forks source link

HTTPUtilities.getFileUploads(...) does not allow access to other form posted parameters (FileItem form fields). #213

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
The HTTPUtilities.getFileUploads(...) methods do not provide a means to get at 
non-file posted fields.

This could be fixed by either:
1) Overloading the methods once again to provide a list that could be populated 
with the form fields.
2) Creating a another method that returns the list of files and the form fields.

I think the second approach would be better, but I wouldn't stop there.  I feel 
the best approach would be to create a new interface and implementation 
specifically for file uploads, which allow returning both types of items.  By 
doing this, the DefaultHTTPUtilities would no longer have a dependency on the 
apache-commons-fileupload code, so applications could use DefaultHTTPUtilities 
and not have to include the fileupload code if it didn't do any file upload.

I've included a patch with the changes I would make.  I didn't create any new 
unit tests, but the existing ones all pass.

Original issue reported on code.google.com by brent.sh...@gmail.com on 4 Mar 2011 at 7:05

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by kevin.w.wall@gmail.com on 18 Sep 2014 at 8:04

GoogleCodeExporter commented 9 years ago

Original comment by kevin.w.wall@gmail.com on 23 Sep 2014 at 1:57

GoogleCodeExporter commented 9 years ago

Original comment by kevin.w.wall@gmail.com on 27 Sep 2014 at 3:10