search

vishapoberon / vipack

vishap package manager
GNU General Public License v3.0
17 stars 5 forks source link

Makefile assumes the voc executable is /opt/voc/bin/voc #3

Open tkurtbond opened 1 day ago

tkurtbond commented 1 day ago

It would probably be better to just let voc be found in the path, leaving it up to the user to ensure that. They've most likely installed voc themselves, and know to add the appropriate directories into the PATH.

Here's the trivial patch. vipack-makefile-patch.txt

tkurtbond commented 1 day ago

Ugh. I see it's more complicated than that. All the dependencies also set VOC to /opt/voc/bin/voc in their Makefiles. I still think that it would be better to let the user set the PATH to specify where the VOC compiler is to be found.

shekspir55 commented 1 day ago

agree @tkurtbond, very good point, would you like to open a PR? we just should make sure that this path is also included.

norayr commented 1 day ago

i pushed the changes you suggested and referenced the issue in the commit.

thank you.