vishesh
commented
7 years ago LGTM. Thanks for fixing this!
Just an advice for next PR. You don't have to make new PR for each update. If you do, git push --force the PR will automatically update itself. So for example. for this issue you created 3 PRs, you could have just force pushed each time and the original PR would have updated itself. Me or @akshatgoel can help you out with that in future if you like.
@akshatgoel : Can you please take a look as well, make the build and do a quick-run? I currently don't have Android environment setup and it can take a while otherwise. If everything looks good from your end too, its all good for merge.
rohitramkumar308
Check for null password and navigate to PasswordActivity if true. When app permissions are revoked manually, the password in the memory is lost and the app crashes.
Pass note to NoteContent.FromString. Tags are passed to NoteContent instead of note that cause the tags to be null when read from parcel.