Closed paulle closed 7 years ago
Thansk @paulle!
here a complete translation into German, see attachment.
Am 18.03.2017 um 20:30 schrieb Vishesh Yadav:
Thansk @paulle https://github.com/paulle!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vishesh/sealnote/pull/46#issuecomment-287569005, or mute the thread https://github.com/notifications/unsubscribe-auth/AEoJbyCcemzqvg5iKSaUi3BztgZwjOEVks5rnDDhgaJpZM4MhfOX.
please delete the first version, here is a better (corrected) on.
Am 18.03.2017 um 20:30 schrieb Vishesh Yadav:
Thansk @paulle https://github.com/paulle!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vishesh/sealnote/pull/46#issuecomment-287569005, or mute the thread https://github.com/notifications/unsubscribe-auth/AEoJbyCcemzqvg5iKSaUi3BztgZwjOEVks5rnDDhgaJpZM4MhfOX.
Hi @paulle, I already merged your previous changes. Please check if that's what you intended to push, or create a new pull request rebased against the develop
branch.
Hi Vishesh, first I corrected a file (aFileChooser/res/values/de/strings.xml), this file you have merged already. Second I translated the file sealnote/Sealnote/src/main/res/values/strings.xml into German (the file attached in my mail). As i don't know nothing about working with github (only reporting an issue from time to time), so I prefered to attch the translation in a mail. So you can can make use of it, if you want a german translation for your fine app. I'm sorry being such a noob, don't want to steal your time.
https://github.com/vishesh/sealnote/tree/4ad95388d4d4354d2c9721cd2bba7bcb7e62ddb6**
Am 20.03.2017 um 19:53 schrieb Vishesh Yadav:
Hi @paulle https://github.com/paulle, I already merged your previous changes. Please check if that's what you intended to push, or create a new pull request rebased against the |develop| branch.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vishesh/sealnote/pull/46#issuecomment-287861509, or mute the thread https://github.com/notifications/unsubscribe-auth/AEoJb9856h07V6ruh3TXSs3SMw3IfLsGks5rnssNgaJpZM4MhfOX.
@paulle, I can't see any attachment with your message. This is Github PR and I guess they don't allow attachment. If you can't figure out a way to create a pull request, just upload it on some pastebin and paste the link here. We will take care of merging your changes.
Thanks again for your time.
Sure it was not visible because it was a .xml-file, I now attach it as .txt.
Am 20.03.2017 um 22:56 schrieb Vishesh Yadav:
@paulle https://github.com/paulle, I can't see any attachment with your message. This is Github PR and I guess they don't allow attachment. If you can't figure out a way to create a pull request, just upload it on some pastebin and paste the link here. We will take care of merging your changes.
Thanks again for your time.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/vishesh/sealnote/pull/46#issuecomment-287910787, or mute the thread https://github.com/notifications/unsubscribe-auth/AEoJb4c6D5LWQxIEuNzpJ-uOFTuCOTbsks5rnvYcgaJpZM4MhfOX.
<?xml version="1.0" encoding="utf-8"?>
@paulle, I've added your changes in commit 33c25e5fb2bf1bd2b1d78c0f1bfa55a20c365dcc. Thanks again!
fixed typo