search

vishesh / sealnote

Android app for keeping encrypted notes
https://play.google.com/store/apps/details?id=com.twistedplane.sealnote
MIT License
79 stars 50 forks source link

Hardcoded string makes sentence untranslatable #58

Closed Tamarindo94 closed 7 years ago

Tamarindo94 commented 7 years ago

There is a hardcoded string in file SealnoteFragment.java, method onAdapterDataSetChanged(). This makes it impossible to translate the string without touching the code. The line I'm talking about is: mEmptyGeneric.setText(getActivity().getActionBar().getTitle() + " is empty!"); https://github.com/vishesh/sealnote/blob/master/Sealnote/src/main/java/com/twistedplane/sealnote/fragment/SealnoteFragment.java#L182

I also noticed that, for dialogues where a "Cancel" button is present, the string for "Cancel" is not read from strings.xml but uses the OS default for the selected language

vishesh commented 7 years ago

@Tamarindo94 Thanks for reporting this. If you are translating this and are planning to submit a PR, you can include a fix for this. Otherwise, I will work on the fix.

Tamarindo94 commented 7 years ago

Pull request sent

vishesh commented 7 years ago

@Tamarindo94 Thank you for fixing this!