search

vishhvaan / eve-pi

The EVolutionary biorEactor (EVE)
MIT License
14 stars 14 forks source link

adding other types of experiments #5

Open wmoebius opened 4 years ago

wmoebius commented 4 years ago

What's the best way to contribute code for other experiments, like just keeping OD constant? As far as we here can see one would need to copy over master.py, but only modify the function control_alg. That seems not ideal as there would be a lot of code duplication.

vishhvaan commented 4 years ago

Commit only that change to your repo and put in a pull request here, I'll merge it with the one here.

wmoebius commented 4 years ago

Guess I was asking on a more conceptual level. Each new experiment would require a lot of duplicate code as you'd only change control_alg. Is there a better way to include a new experiment?

vishhvaan commented 4 years ago

Are you referring to running different experiments on multiple culture units? There should only be one program running at a time for each morbidostat at a time. If more than one is running, you will face problems communicating with the ICs.

To run different experiments on different culture units simultaneously, modify the control_alg function to add the new code and add a switch parameter in the conf file (I believe I have already done something similar). If you mean running a different experiment entirely, I would still add the new code to control_alg and make all the switches in the conf file the same.

I'm not sure if I'm answering what you asked. If I haven't, I'm happy to talk about this on a call!