search

vishnuvk47 / pe

0 stars 0 forks source link

Module that cannot be SU'ed can be SU'ed #11

Open vishnuvk47 opened 1 year ago

vishnuvk47 commented 1 year ago

Screenshot 2023-04-14 at 5.05.28 PM.png

EE2211 has a prerequisite and hence i don't think it can be SU'ed.

nus-pe-script commented 1 year ago

Team's Response

CS/CU grade is not handled appropriately, same as #2485

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Does not check for whether a mod can be SU or if it is CS/CU

With access to the NUSMod API, perhaps there should be validation to check whether the modules are able to be SU-ed, or if they are CS/CU.

As shown below, CS2040, which is not a CS/CU mod can be marked as such, and CFG, which is a CS/CU mod, can be given a grade. This can lead to inaccurate reporting of CAP and planning, which is why I've marked it as medium

image.png

[original: nus-cs2113-AY2223S2/pe-interim#2231] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

CS/CU feature was proposed in the DG, and has not been fully implemented.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Medium`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]