vishnuvk47 / pe

0 stars 0 forks source link

X at the end of a lifeline should not overlap with the "return" #18

Open vishnuvk47 opened 1 year ago

vishnuvk47 commented 1 year ago

Screenshot 2023-04-14 at 5.37.27 PM.png

Both 'X' overlap with the "return" arrow. A function only ends its lifeline AFTER it returns not during its return

soc-pe-bot commented 1 year ago

Team's Response

Textbook does not mention the format of object deletion as you mentioned. Meaning of the Sequence diagram is still understood by the readers.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Perhaps if there was no return then doing as what the Dev team has done would be somewhat acceptable. however, since there is a return, an object deletion would only occur AFTER this happens not during or before as would have been indicated by the initial diagram. this is not the conventional way to do this and I have also clarified about this issue with my TA during one of the previous tutorials.