vishnuvk47 / pe

0 stars 0 forks source link

Command read in wrong format #5

Open vishnuvk47 opened 1 year ago

vishnuvk47 commented 1 year ago

Screenshot 2023-04-14 at 4.42.25 PM.png

the UG specifies appropriate order as "taken [mod] y/[year] s/[sem] g/[grade]"

but when I swap the order and do s/[sem] before y[year] instead of an error it read the sem entry as year and year entry as sem.

nus-pe-script commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Incorrect output when input is in wrong order happens with list command as well

Screenshot 2023-04-14 at 5.19.10 PM.png

Should be handled as an exception or input be read as appropriate using flags


[original: nus-cs2113-AY2223S2/pe-interim#1260] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Should be a featureflaw as it deals with the order of the flags.

Severity should be low as it only appears in rare situations when a user does not follow the intended formatting. It does not affect the normal operations according to the tester's bug report.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: conditions to mark under duplicate:

Screenshot 2023-04-20 at 10.35.14 PM.png

(a): With regard to point a, this is definitely not the EXACT same bug as it happens for a different command.

(b): See below for teams code on how parser is implemented, each command has its own method where the relevant parsing is done; hence, solving one doesn't resolve all the others as they will need to make changes to all the other methods as well.

Screenshot 2023-04-20 at 10.35.23 PM.png


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** Nowhere in the UG is it stated that the commands must be executed in a specific order, which is a crucial point to consider when the program uses flags to track input. However, if the program does not use flags, it can be assumed intuitively that the commands need to be in a certain order. In light of this, it opens the question of why flags are used if the order cannot be changed. Additionally, if the order does matter, it may be better to eliminate the use of flags altogether, as this would remove the need for users to type the special character "/" and reduce the number of characters they need to input by six. This would optimize the program for its intended audience and facilitate faster typing. Guidelines describe feature flaw as: Missing features and problems in how a feature is designed are considered feature flaws i.e., type.FeatureFlaw. I did accidently identify this bug as a functionalityBug however as the team noted this is indeed a feature flaw and cannot be rejected.
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.High`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]