search

vishtheshnu / AdminShop

My first minecraft mod for 1.12! Provides means to buy and sell items and fluids using in-game money.
Other
3 stars 3 forks source link

Crash when auto-seller receives item stack of size larger than 64 #10

Open asawula opened 4 years ago

asawula commented 4 years ago

This mod is fantastic. I love it. I found a case where if the auto-buyer creates an item stack larger than 64, and it is fed right back to the auto-seller, it crashes the game. I would be ok with limiting the auto-buy size to 64 as a solution. Limiting the auto-buy amount and frequency (for server performance savings) via config would be a nice-to-have.

Thanks!

edit - Items were transferred with IE conveyors

vishtheshnu commented 4 years ago

Nice find! I'll implement a fix for it, and add a config based limiter for servers.

On Sun, Oct 27, 2019 at 11:08 AM Alan Sawula notifications@github.com wrote:

This mod is fantastic. I love it. I found a case where if the auto-buyer creates an item stack larger than 64, and it is fed right back to the auto-seller, it crashes the game. I would be ok with limiting the auto-buy size to 64 as a solution. Limiting the auto-buy amount and frequency (for server performance savings) via config would be a nice-to-have.

Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vishtheshnu/AdminShop/issues/10?email_source=notifications&email_token=ABRSK7ZNJJKK72PHEUF4ADDQQXKH7A5CNFSM4JFSYSJKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HUTYSRA, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRSK7574J4GFX64QKGX6B3QQXKH7ANCNFSM4JFSYSJA .

-- Sincerely,

Vishnu Narayana

asawula commented 4 years ago

Thanks!

nematrec commented 4 years ago

Gonna add on to this, any time more than 1 item stack would be inserted into the seller in a single tick causes a crash.

Be it 65+ of an item, or just 1 of one item and 1 of another item.

It also doesn't seem to matter what is used to insert the items, as long as it all arrives in the same tick.

Can be replicated with 2 hoppers, each with a different item, then placing the seller next to them (such that they insert into the seller).

Only way to fix seems to be MCedit to delete the seller in question.

Crashlog from one of my tests https://pastebin.com/tscdvrKB

BLAMM67 commented 4 years ago

Also adding to this instead of reporting a new issue. More logs is more better. https://pastebin.com/GgXUhqV8

Happens to a seller I have connected to a redstone farm. Pulling from a single Actually Additions farmer with EnderIO Item conduit into the seller worked fine for several days. Hooking a second farmer up causes the crash after a few minutes. Repeatedly and consistently. Given nematrec's comment about it happening with two different items, I'm guessing it's because one farmer outputs a redstone dust when the other outputs a seed.