vishtheshnu / Trillionaire-Bug-Reports

Make trillionaire bug reports here. Will be closed after final update
0 stars 0 forks source link

Uranium fuel rods can't be sold #26

Open michaelPoul opened 2 years ago

michaelPoul commented 2 years ago

Newly crafted IC2 uranium fuel rods can't actually be sold in the shop

the issue is because the shop entry expects that the fuel rods have the advDmg nbt tag: sell,<ic2:uranium_fuel_rod>.withTag({advDmg: 0}),300,1, However, while that tag shows up in JEI, crafted rods don't have that tag. The tag is only added when rods take damage inside the ic2 reactor. I managed to get it work by changing the shop entry to: sell,<ic2:uranium_fuel_rod:0>,300,1, which limits sale to rods that haven't taken any damage.

vishtheshnu commented 2 years ago

Thanks for the catch, and solution!

On Wed, Nov 3, 2021 at 9:48 PM Michael @.***> wrote:

Newly crafted IC2 uranium fuel rods can't actually be sold in the shop

the issue is because the shop entry expects that the fuel rods have the advDmg nbt tag: sell,.withTag({advDmg: 0}),300,1, However, while that tag shows up in JEI, crafted rods don't have that tag. The tag is only added when rods take damage inside the ic2 reactor. I managed to get it work by changing the shop entry to: sell,,300,1, which limits sale to rods that haven't taken any damage.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vishtheshnu/Trillionaire-Bug-Reports/issues/26, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRSK72HIKLNULBMJCAQBXTUKINCFANCNFSM5HKSAV4A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Sincerely,

Vishnu Narayana