Enable errcheck, errorlint, gci and gofumpt linters

vishvananda / netns

Simple network namespace handling for go.

Apache License 2.0

379 stars 133 forks source link

Enable errcheck, errorlint, gci and gofumpt linters #69

Closed mmorel-35 closed 1 year ago

mmorel-35 commented 1 year ago

Signed-off-by: Matthieu MOREL matthieu.morel35@gmail.com

jeffwidman commented 1 year ago

Curious what prompted this and also why you closed it?

mmorel-35 commented 1 year ago

Just wanted to add more linters But gofumpt is failing on windows I have no clue why 😅

jeffwidman commented 1 year ago

Weird. And 👍 in general for more linters if you choose to add them. I personally like goimports, not sure if that's included indirectly in this list...

mmorel-35 commented 1 year ago

Hi @jeffwidman , I have opened #71 instead, goimports and gci are doing thesame job. From what I can see on other projects gci is frequently used because of its flexibility