search

vishysank / console-log-atom

A console.log generator for atom editor
MIT License
21 stars 2 forks source link

no semicolon at the end of console.log, reason for uppercase identifier #12

Closed psycalc closed 8 years ago

psycalc commented 8 years ago

Why uppercase? where is the semicolon? Escape charater for qoutes? Example at line 28, 29, Opportunity to replace (maybe in settings) curretn line $1 with console.log($1);

current behavior:

console-log-issue

expected behavior:

console-log-issue

vishysank commented 8 years ago

@designofhumanity,

re: the uppercase, that is a default behaviour, i chose it to make the identifier standout. There is actually a configuration in the package that should let you choose the case of the identifier (refer image)

same thing for semicolons, the linter I tend to use does not really care about semicolons, but it is a configuration.

screen shot 2016-09-07 at 7 55 13 pm
vishysank commented 8 years ago

@designofhumanity ,

good point about escape character for quotes, and ignoring a semicolon at the end, I'm a bit strapped for time so if you want to submit a PR that would be great, or I shall look into this a bit later. I'm going to close this and open a new bug with these two points for clarity.