search

vishysank / console-log-atom

A console.log generator for atom editor
MIT License
21 stars 2 forks source link

Missing semicolons #2

Closed joshstar closed 8 years ago

joshstar commented 8 years ago

I know that semi-colons are not at required by any means in Javascript but it is still far more common to include them rather then to omit them.

Many Javascript apps require building and usually enforce a consistent style guide, not having the semi colon would make the builds fail.

Providing an option to include a semicolon would be the best for both worlds, if its not to complex to implement.

wilmoore commented 8 years ago

Perhaps check if selected line has a semicolon and if so, add one, if not, skip it.

vishysank commented 8 years ago

this is a good suggestion, thanks for bringing it up. I am so used to coding in Javascript Standard Style that I did not think about this. I will add a package configuration option in an update in a few days.

vishysank commented 8 years ago

@Josh-Star and @wilmoore this should now be a configurable options as of v0.6.2. Check it out and let me know if you see any further issues