search

visiblevc / wordpress-starter

A slightly less shitty wordpress development workflow
688 stars 167 forks source link

Allow to specify a different database charset via environment variable #137

Closed signaleleven closed 6 years ago

signaleleven commented 6 years ago

I had to import a database from a very old wordpress instance, created before the standard charset for the database was utf8. This change came in handy to configure wordpress accordingly. (when converting the database is not an easy option)

This comes with a sensible default, and it's harmless if not used.

dsifford commented 6 years ago

No objections. Seems reasonable.

signaleleven commented 6 years ago

Sorry, I amended the commit and now this PR is a bit ugly :) But I changed what was requested.

karellm commented 6 years ago

@signaleleven You missed one space before the second pipe :trollface:

signaleleven commented 6 years ago

Third time's the charm? :D

karellm commented 6 years ago

@signaleleven Thanks for the contribution

@dsifford LGTM, can I ask you to merge and deploy a new version?

dsifford commented 6 years ago

@karellm Yeah, I can deploy.

I have one little thing I'm gonna add and PR this morning though that's separate from this PR. I'd prefer to push both updates at the same time if possible.