search

visiblevc / wordpress-starter

A slightly less shitty wordpress development workflow
688 stars 167 forks source link

greatly simplify runtime script #165

Closed dsifford closed 4 years ago

dsifford commented 4 years ago

This PR seeks to greatly simplify the process of bootstrapping a wordpress installation from how we've done it in the past.

Previously, there was no way to do a clean install of wordpress without default plugins and themes, so we did a really complex method of checking for dependencies and then went through and manually deletes plugins/themes that didn't check out. There are several problems/quirks with doing it this way and I think we've talked about them in the past and just delt with them.

Now wp-cli allows you to download wordpress without the wp-content directory. So there really is no need to do this convoluted volume check anymore.

So that's the biggest change I made. I did another quick once over and made sure everything else checked out still and adjusted misc stuff during that little process (I'll look and comment on notable stuff inline in this PR if there are any).

Ping @karellm

dsifford commented 4 years ago

It should probably be noted that we've had the ability to do it in this simplified way for what appears to be 2 entire years but for whatever reason I must have enjoyed making more work for myself.

dsifford commented 4 years ago

I just built and tested the images and it works as expected. So I'm gonna go ahead and merge this and push them out because I'm low on time.

If you're not fond of the last min changes, I'll roll back and push another version. But I can't think of any reason why you wouldn't be.